Jump to content

Some web services and downloads are currently unavailable due to internal restructuring. In the meantime you can probably find what you're looking for in our Discord chat server. For more information, check the newsfeed or ask in Discord.

(AMC)

Minecraft mod pack created for Asterion Minecraft

This is a legacy project. Support for this project was discontinued in January 2016.

While Ginever Entertainment no longer provides any official support for this project, you may be able to find help within the wider Ginever community. For more information, feel free to ask in the forums or in our Discord server.

Sign in to follow this  
AMC-85 (Bug)

Many bugs with IC2 alcohol

Description

Current issues:

  • Alcohol is listed in NEI incorrectly (previously displayed as "Zero" and now appears as "Booze") because getSubItems isn't implemented for ItemBooze.  (Logged in JIRA so that people will cease asking why I have disabled alcohol, even though I haven't.)
  • The flag that indicates there are multiple varieties of the item is not set, which results in bad sorting by invtweaks.
  • A negative metadata issue with more recent MC versions results in some booze types not being obtainable.
  • Some metadatas of booze cause a client crash.

[See comments further down for additional details]

Related Issues

This issue is not related to any other issues

User Feedback

Recommended Comments

Tinytimrob
Issue Creator Current Assignee Project Manager Programming Lead

Posted

Should now appear as "Booze" in NEI... still needs work though

Share this comment


Link to comment
Share on other sites
Tinytimrob
Issue Creator Current Assignee Project Manager Programming Lead

Posted

"The flag that indicates there are multiple varieties of the item is also not set" -> also seems to be affecting Inventory Tweaks sorting alcohol.

Share this comment


Link to comment
Share on other sites
Tinytimrob
Issue Creator Current Assignee Project Manager Programming Lead

Posted

Booze design comments

There are 3 booze types, with type parameter set on the rightmost 2 bits (if T was type, binary of metadata is XXXX-XXXX-XXXX-XXTT):

  • 0 = Not set
  • 1 = Beer
  • 2 = Rum

The next 5 bits labelling as A (XXXX-XXXX-XAAA-AATT) are used for the total amount, and only on barrel side. Thus, for the item these metas do absolutely nothing.

The remaining bits change depending on if beer or rum.

Beer

For beer, the additional bits are for Solid Ratio (labelling as S between 0 and 6), Hops Ratio (labelling as H between 0 and 6), and Time Ratio (labelling as M between 0 and 5). The layout of these bits is MMMH-HHSS-SAAA-AATT. 

Solidness values:

  • 0 = Watery
  • 1 = Clear
  • 2 = Lite
  • 3 = [blank]
  • 4 = Strong
  • 5 = Thick
  • 6 = Stodge

Hops values:

  • 0 = Soup
  • 1 = Alcfree
  • 2 = White
  • 3 = [blank]
  • 4 = Dark
  • 5 = Full
  • 6 = Black

Time values:

  • 0 = Brew
  • 1 = Youngster
  • 2 = Beer
  • 3 = Ale
  • 4 = Dragonblood
  • 5 = Black Stuff

If the time value is "black stuff" then the solidness and hops values are ignored, and drinking the booze will always result in a random debuff taken from a list, without any positive effects being possible.

Rum

For rum, an additional 7 bits are exclusively used for a "progress" value of up to 100 (the layout is XXPP-PPPP-PAAA-AATT, with the X bits unused). Max progress value is actually technically 127.

If the progress value is 100 or more, the rum is drunk normally. If not, the rum is treated as "black stuff" beer and has the same effect as that beer.

 

New bugs discovered while learning how the metadata works:

Unfortunately, due to an oversight which has been completely missed by the IC2 devs, beer with time values of 4 and 5 (dragonblood and black stuff, respectively) require setting the left-most bit to 1. Since the item damage is loaded and saved to NBT as a short in MC 1.7 (and I think maybe also 1.6), this bit is now the sign bit and thus sets the meta to negative. Since negative metas aren't allowed, this results in the "dragonblood" and "black stuff" booze types being completely unobtainable.

Setting the solidness or hops values of beer to 7 will result in item with name of "X" for that field. Attempting to drink these results in array index OOB exception that crashes the client. If time values of 6 or 7 were actually possible (rather than not being possible due to negative metadata oversight), the same crash would also result.

Share this comment


Link to comment
Share on other sites
Tinytimrob
Issue Creator Current Assignee Project Manager Programming Lead

Posted

I updated the issue description with the new bugs.

Share this comment


Link to comment
Share on other sites
Tinytimrob
Issue Creator Current Assignee Project Manager Programming Lead

Posted

Marked issue as resolved in version Fondant 27 DEV8 [r4978] (158b4490d35c)

Resolved in 27 DEV8.

Share this comment


Link to comment
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Create a new GineverAccount today. It's easy!

Register a new account

Sign In with GineverAccount 5.1

Already have an account? Sign in here.

Sign In Now
×